A year ago, the name H.R. McMaster would have evoked near-unanimous praise from the national security community. He was a venerated tank commander and counterinsurgency warrior who earned a PhD in history. He wrote a widely praised book about the failure of military leaders to challenge civilian leadership on Vietnam War strategy.